fix(core): validate replay operation identity - #698

Open

zhongkechen wants to merge 4 commits into

mainfrom

fix/replay-operation-identity

zhongkechen commented Aug 31, 2026

Contributor

Summary

validate checkpoint type, subtype, and name before operation-specific replay handling
fail mismatches with NonDeterministicExecutionError instead of consuming another operation's checkpoint
cover type, subtype, and name drift through unit and end-to-end regression tests

Testing

1,587 core non-e2e tests passed
46 core e2e tests passed
hatch run dev-core:typecheck
hatch fmt --check

Closes #692


          fix(core): validate replay operation identity

7a65d6c

zhongkechen temporarily deployed to ai-pr-review-runtime

August 31, 2026 18:58

— with

GitHub Actions Inactive

zhongkechen had a problem deploying to ai-pr-review-runtime

August 31, 2026 19:11

— with

GitHub Actions Failure

zhongkechen had a problem deploying to ai-pr-review-runtime

August 31, 2026 19:11

— with

GitHub Actions Failure

zhongkechen commented

View reviewed changes

.../aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/operation/callback.py Outdated


          Merge branch 'main' into fix/replay-operation-identity

335b745

zhongkechen had a problem deploying to ai-pr-review-runtime

August 31, 2026 19:31

— with

GitHub Actions Failure

zhongkechen temporarily deployed to ai-pr-review-runtime

August 31, 2026 19:31

— with

GitHub Actions Inactive

github-actions Bot reviewed

View reviewed changes

...ws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/concurrency/executor.py Outdated

github-actions Bot reviewed

View reviewed changes

packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/identifier.py

github-actions Bot reviewed

View reviewed changes

...ges/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/operation/child.py Outdated

This comment has been minimized.

Sign in to view


          fix(core): preserve nondeterminism across nested replay

d8f9c98

zhongkechen had a problem deploying to ai-pr-review-runtime

August 31, 2026 22:50

— with

GitHub Actions Failure

zhongkechen temporarily deployed to ai-pr-review-runtime

August 31, 2026 22:50

— with

GitHub Actions Inactive

github-actions Bot reviewed

View reviewed changes

...ws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/concurrency/executor.py

github-actions Bot reviewed

View reviewed changes

...ws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/concurrency/executor.py Outdated

github-actions Bot commented Aug 31, 2026

Contributor

Codex AI review

Two P1 replay-safety gaps remain in concurrent map/parallel handling. Tests do not cover early-completion races or actual NESTED→FLAT replay.

Reviewed commit d8f9c9846eb9aef8367324e72bf72f55f170293b. Workflow run


          fix(core): preserve late replay failures

7e852e4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet