Repository navigation
Add 1 person override GitHub action - #2590
Merged
Merged
Conversation
Contributor
|
The description doesn't sound correct so I am trying to determine actual intent: Why would we need 1p-approval if we are reducing the require approval count to 1. You would need a 2p-approval label if reducing the rules. Or are the required approvals staying at 2? |
boblodgett
reviewed
Oct 7, 2026
boblodgett
approved these changes
Oct 9, 2026
dscpinheiro
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
To cut down the boiler plate time for smaller PR we want to experiment with allowing small PRs to opt-in to reducing reviewer approval to 1 person. By default 2 people will still be required unless the
1p-approvallabel is applied by somebody withwriteoradminpermissions.The PR adds the GitHub action that will enforce that 2 people with
writeoradminaccess has approved the PR. After this PR is merged we'll change the GitHub settings to reduce the required approval count to 1 and create the1p-approvallabel.The action works by running on new PRs being changed or labels applied or removed. It will fail if there are not 2 approvals or 1 approval and the
1p-approvallabel is not applied.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.