Skip to content

Add 1 person override GitHub action - #2590

Merged
dscpinheiro merged 1 commit into
masterfrom
normj/ga-1p
Oct 9, 2026
Merged

dscpinheiro merged 1 commit into
masterfrom
normj/ga-1p

Conversation

@normj

@normj normj commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Description of changes:
To cut down the boiler plate time for smaller PR we want to experiment with allowing small PRs to opt-in to reducing reviewer approval to 1 person. By default 2 people will still be required unless the 1p-approval label is applied by somebody with write or admin permissions.

The PR adds the GitHub action that will enforce that 2 people with write or admin access has approved the PR. After this PR is merged we'll change the GitHub settings to reduce the required approval count to 1 and create the 1p-approval label.

The action works by running on new PRs being changed or labels applied or removed. It will fail if there are not 2 approvals or 1 approval and the 1p-approval label is not applied.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@normj
normj requested review from a team as code owners October 7, 2026 20:22
@boblodgett

boblodgett commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

The description doesn't sound correct so I am trying to determine actual intent:

After this PR is merged we'll change the GitHub settings to reduce the required approval count to 1 and create the 1p-approval label.

Why would we need 1p-approval if we are reducing the require approval count to 1. You would need a 2p-approval label if reducing the rules. Or are the required approvals staying at 2?

Comment thread .github/workflows/required-approvals.yml
Comment thread .github/workflows/required-approvals.yml
@dscpinheiro dscpinheiro added the Release Not Needed Add this label if a PR does not need to be released. label Oct 9, 2026
@dscpinheiro
dscpinheiro merged commit 8423be2 into master Oct 9, 2026
9 of 17 checks passed
@dscpinheiro
dscpinheiro deleted the normj/ga-1p branch October 9, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Release Not Needed Add this label if a PR does not need to be released.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants