[Feature] Adjusts request signing timestamps - #3906
Open
kai-ion wants to merge 1 commit into
Open
Conversation
kai-ion
force-pushed
the
timechange
branch
3 times, most recently
from
August 31, 2026 19:25
1b3f4d1 to
969f1d6
Compare
kai-ion
marked this pull request as ready for review
August 31, 2026 20:08
sbiscigl
reviewed
Sep 1, 2026
| @@ -138,6 +134,7 @@ AWSClient::AWSClient(const Aws::Client::ClientConfiguration& configuration, | |||
| m_hash(Aws::Utils::Crypto::CreateMD5Implementation()), | |||
| m_requestTimeoutMs(configuration.requestTimeoutMs), | |||
| m_enableClockSkewAdjustment(configuration.enableClockSkewAdjustment), | |||
| m_clientSkew(Aws::MakeShared<Aws::Internal::ClientSkew>(AWS_CLIENT_LOG_TAG, std::chrono::milliseconds(0))), | |||
Collaborator
There was a problem hiding this comment.
why does it need to be a a shared pointer, why cant it just be a stack variable?
| @@ -320,6 +309,10 @@ HttpResponseOutcome AWSClient::AttemptExhaustively(const Aws::Http::URI& uri, | |||
| {TracingUtils::SMITHY_SERVICE_DIMENSION, this->GetServiceClientName()}}); | |||
| if (outcome.IsSuccess()) | |||
| { | |||
| if (m_enableClockSkewAdjustment && outcome.GetResult()) | |||
Collaborator
There was a problem hiding this comment.
why are we only measuring clockskew if the result is success? wouldnt we also want to measure for failures?
|
|
||
| // A MockAWSClient whose error responses carry a service error code via the x-amzn-errortype header | ||
| // (the header a JSON error marshaller reads), so a clock-skew retry can be exercised end to end. | ||
| class ClockSkewMockAWSClient : public MockAWSClient |
Collaborator
There was a problem hiding this comment.
why do you need this in addition to mock aws client? why do you need to override BuildAWSError when supplying a expected response to a public API is how that class is supposed to be used?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Wire clock-skew correction into the legacy and smithy client pipelines
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.