Skip to content

Pass service name to Smithy endpoint providers - #3908

Closed
Renz456 wants to merge 1 commit into
aws:mainfrom
Renz456:rene/sts-param-fix
Closed

Pass service name to Smithy endpoint providers#3908
Renz456 wants to merge 1 commit into
aws:mainfrom
Renz456:rene/sts-param-fix

Conversation

@Renz456

@Renz456 Renz456 commented Aug 31, 2026

Copy link
Copy Markdown

Issue #, if available:

Fixes #3907.

Description of changes:

Pass the service name stored by AwsSmithyClientT to InitBuiltInParameters. This allows Smithy-based clients such as STS to resolve service-specific and global endpoint URL configuration consistently with non-Smithy generated clients.

Add a core unit test that verifies Smithy client construction selects the service-aware endpoint-provider overload and supplies the expected service name.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

Generated with AI tooling and reviewed by Rene Ravanan.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Renz456
Renz456 force-pushed the rene/sts-param-fix branch from 1361185 to c4ca155 Compare August 31, 2026 20:14
@sbiscigl

Copy link
Copy Markdown
Collaborator

yep looks goods, for process reasons i need to pull your commit onto a branch I own and can merge it from there. the commit will still credit you.

@sbiscigl

sbiscigl commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

merged #3909 with your commit on it, thanks for the contribution

@sbiscigl sbiscigl closed this Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AwsSmithyClientT does not pass in m_serviceName param when initialising endpointProvider

2 participants