Pass service name to Smithy endpoint providers - #3908
Closed
Renz456 wants to merge 1 commit into
Closed
Conversation
Renz456
force-pushed
the
rene/sts-param-fix
branch
from
August 31, 2026 20:14
1361185 to
c4ca155
Compare
Collaborator
|
yep looks goods, for process reasons i need to pull your commit onto a branch I own and can merge it from there. the commit will still credit you. |
11 tasks
Collaborator
|
merged #3909 with your commit on it, thanks for the contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #3907.
Description of changes:
Pass the service name stored by
AwsSmithyClientTtoInitBuiltInParameters. This allows Smithy-based clients such as STS to resolve service-specific and global endpoint URL configuration consistently with non-Smithy generated clients.Add a core unit test that verifies Smithy client construction selects the service-aware endpoint-provider overload and supplies the expected service name.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
Generated with AI tooling and reviewed by Rene Ravanan.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.