fix(identity): update endpoint for Create/UpdateWorkloadIdentity#249
Merged
fix(identity): update endpoint for Create/UpdateWorkloadIdentity#249
Conversation
Contributor
|
Please expand on this issue: |
SkyWalker-CMD
approved these changes
Feb 4, 2026
brianlaoaws
approved these changes
Feb 4, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
=======================================
Coverage ? 90.52%
=======================================
Files ? 35
Lines ? 3421
Branches ? 511
=======================================
Hits ? 3097
Misses ? 179
Partials ? 145
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jariy17
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This change updates the identity client to use the control plane endpoint for Create/UpdateWorkloadIdentity.
The Create/UpdateWorkloadIdentity functions were originally set up to use clients using the AgentCore data plane endpoint to avoid an old issue with local development. This issue has been fixed already, so these functions should use the control plane endpoint like the rest of the control plane operations.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.