fix: Pipeline TypeError: can only concatenate list (not "NoneType") to list Using Sou (#5518)#5676
Closed
aviruthen wants to merge 1 commit intoaws:masterfrom
Conversation
…o list Using Sou (aws#5518)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The bug is a TypeError in
get_training_code_hash()insagemaker-core/src/sagemaker/core/workflow/utilities.py. When a user creates aSourceCodeobject without specifyingrequirements(which defaults toNone), and then uses it in a Pipeline withpipeline.upsert(), the code pathget_code_hash()->get_training_code_hash()attempts to concatenate[source_dir] + dependencieswheredependenciesisNone, causingTypeError: can only concatenate list (not 'NoneType') to list. The fix is already present in the current codebase on master: theget_training_code_hash()function now checksif dependencies:before concatenating, and falls back tohash_files_or_dirs([source_dir])orhash_files_or_dirs([entry_point])when dependencies is None. The fix also corrected the concatenation from+ dependencies(expecting a list) to+ [dependencies](wrapping the string in a list). The existing testtest_get_training_code_hash_with_source_dircovers thedependencies=Nonecase.Related Issue
Fixes #5518
Changes Made
sagemaker-core/src/sagemaker/core/workflow/utilities.pyAI-Generated PR
This PR was automatically generated by the PySDK Issue Agent.
Merge Checklist
prefix: descriptionformat