fix(deploy-on-aws): shorten MCP server names for Bedrock 64-char limit#133
Open
Sagargupta16 wants to merge 2 commits intoawslabs:mainfrom
Open
fix(deploy-on-aws): shorten MCP server names for Bedrock 64-char limit#133Sagargupta16 wants to merge 2 commits intoawslabs:mainfrom
Sagargupta16 wants to merge 2 commits intoawslabs:mainfrom
Conversation
Sagargupta16
requested review from
a team,
Copilot,
krokoko,
scottschreckengaust and
theagenticguy
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the deploy-on-aws plugin’s MCP server keys to shorter names to avoid exceeding AWS Bedrock Converse API’s 64-character toolSpec.name limit.
Changes:
- Renamed MCP server keys in
deploy-on-awsfromawsiac/awsknowledge/awspricingtoiac/knowledge/pricing. - Updated plugin documentation and skill reference docs to use the new MCP server names.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| plugins/deploy-on-aws/.mcp.json | Renames MCP server keys to shorter identifiers. |
| plugins/deploy-on-aws/README.md | Updates MCP server names in plugin documentation. |
| plugins/deploy-on-aws/skills/deploy/SKILL.md | Updates skill docs to refer to knowledge/pricing/iac. |
| plugins/deploy-on-aws/skills/deploy/references/security.md | Updates MCP references to new server keys. |
| plugins/deploy-on-aws/skills/deploy/references/defaults.md | Updates awsknowledge mention to knowledge. |
| plugins/deploy-on-aws/skills/deploy/references/cost-estimation.md | Updates awspricing mention to pricing. |
Sagargupta16
force-pushed
the
fix/shorten-mcp-server-names
branch
from
bb84d66 to
1db3d47
Compare
Contributor
|
thanks @Sagargupta16 , could you pelase have a look at the copilot comments ? |
Rename MCP server keys from awsiac/awsknowledge/awspricing to iac/knowledge/pricing. Claude Code constructs tool names as mcp__plugin_<plugin>_<server>__<tool>, and the old names caused the full tool name to exceed Bedrock Converse API's 64-character constraint (ValidationException). Before: mcp__plugin_deploy-on-aws_awsknowledge__get_regional_availability (69 chars) After: mcp__plugin_deploy-on-aws_knowledge__get_regional_availability (63 chars) Updated all references in SKILL.md, README.md, and reference docs. Fixes awslabs#131
Copilot review flagged references to the old server keys (awsknowledge/ awspricing/awsiac) in repo-level docs that were missed in the initial commit. Updated only references scoped to the deploy-on-aws plugin: - AGENTS.md: glossary example + deploy-on-aws server table - README.md: deploy-on-aws MCP Servers table - README.jp.md: deploy-on-aws MCP Servers table (Japanese) - docs/TROUBLESHOOTING.md: generic MCP troubleshooting reference - .github/copilot-instructions.md: generic tools list Intentionally left alone: awsknowledge/awsiac references inside codebase-documentor-for-aws and databases-on-aws sections, which are separate plugins whose own .mcp.json still uses those keys.
Sagargupta16
force-pushed
the
fix/shorten-mcp-server-names
branch
from
98beea0 to
a899e94
Compare
Contributor
Author
|
Thanks @krokoko — fixed both: Stale doc refs — updated the deploy-on-aws references in 64-char validation — checked every tool name:
So this PR fully resolves #131 for Knowledge + Pricing, and shrinks the IAC problem from 9 tools to 4. Happy to file the upstream issue if useful. Build was just flaky (git-cleanup log, no real failure) — re-running now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
awsiac->iac,awsknowledge->knowledge,awspricing->pricingValidationExceptionwhen using the plugin through AWS Bedrock's Converse APIProblem
Claude Code constructs MCP tool names as
mcp__plugin_<plugin-name>_<server-name>__<tool-name>. With the old server names, the prefix alone was 40+ characters, causing several tool names to exceed Bedrock's 64-charactertoolSpec.namelimit:Fix
Shortened server keys by dropping the
awsprefix (redundant since the plugin is already calleddeploy-on-aws):awsiaciacawsknowledgeknowledgeawspricingpricingAfter:
mcp__plugin_deploy-on-aws_knowledge__get_regional_availability(63 chars)Updated all references in
.mcp.json,README.md,SKILL.md, and reference docs.Related
Fixes #131
Changes
Renamed MCP server keys in
.mcp.jsonand updated all documentation references acrossREADME.md,SKILL.md, and reference files.Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.