Conversation
Lines like "- [ ] - 12:30 - [[some text]] #idea" caused the timestamp to appear in the converted entity name (e.g. "- 1230 - some text") because marker stripping in deriveTitle and hasMeaningfulContent did only a single pass, leaving a trailing "- " and the timestamp intact. Fix: make list/task marker stripping iterative in deriveTitle, deriveText, and hasMeaningfulContent so that separators like the "- " after "[ ] " are also removed. Then strip a leading HH:MM timestamp (optionally followed by a separator dash) from the derived title and from the meaningful-content check so that timestamps used as time annotations never become part of the entity name. Unresolved-wikilink (Case 1) detection for this line format already worked correctly; the bug was exclusively in the Case 2 (full-line) code path used when the wikilink is already resolved. https://claude.ai/code/session_01BZTFhMA7o6caXwAW5yDaYH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lines like "- [ ] - 12:30 - [[some text]] #idea" caused the timestamp
to appear in the converted entity name (e.g. "- 1230 - some text")
because marker stripping in deriveTitle and hasMeaningfulContent did
only a single pass, leaving a trailing "- " and the timestamp intact.
Fix: make list/task marker stripping iterative in deriveTitle,
deriveText, and hasMeaningfulContent so that separators like the "- "
after "[ ] " are also removed. Then strip a leading HH:MM timestamp
(optionally followed by a separator dash) from the derived title and
from the meaningful-content check so that timestamps used as time
annotations never become part of the entity name.
Unresolved-wikilink (Case 1) detection for this line format already
worked correctly; the bug was exclusively in the Case 2 (full-line)
code path used when the wikilink is already resolved.
https://claude.ai/code/session_01BZTFhMA7o6caXwAW5yDaYH