Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
8214422
Don't leave a trailing slash for the root package.
rsartor-cmd Jun 26, 2026
1e89b99
Remove duplicate assignment.
rsartor-cmd Jun 26, 2026
d921d20
Remove typical C-style integer suffixes before parsing.
rsartor-cmd Jun 26, 2026
f318173
Fix check for filename.
rsartor-cmd Jun 26, 2026
80a9aae
Remove unnecessary guard.
rsartor-cmd Jun 26, 2026
9bfc331
Re-format docstring.
rsartor-cmd Jun 26, 2026
e85e06b
Get the platform from the constraints.
rsartor-cmd Jun 29, 2026
590b667
Adjust formatting syntax.
rsartor-cmd Jun 29, 2026
15c95f8
Change the default value.
rsartor-cmd Jun 29, 2026
daa2455
Add more test cases for py_limited_api.
rsartor-cmd Jun 29, 2026
030c879
Use RunfilesBuilder instead of manual.
rsartor-cmd Jun 29, 2026
73eb7c0
Add abi_tag to PyCcToolchainInfo.
rsartor-cmd Jun 30, 2026
5cb7c90
Use the PyCcToolchainInfo to derive the filename instead of the runti…
rsartor-cmd Jun 30, 2026
797bf98
Remove the fallback. Determine platform tag solely from constraints.
rsartor-cmd Jun 30, 2026
09a2e0a
Remove the version compatibility check, as it has performance implica…
rsartor-cmd Jun 30, 2026
5bbe09f
Fix header filename.
rsartor-cmd Jun 30, 2026
475ed3d
Update python/private/cc/py_extension_rule.bzl
rsartor-cmd Jun 30, 2026
903c96a
ruff
rsartor-cmd Jun 30, 2026
9570a98
Derive the values for the _constraints attr programmatically, instead…
rsartor-cmd Jun 30, 2026
7179c8a
Take glibc-vs-musl into account, so we get the right platform and name.
rsartor-cmd Jun 30, 2026
b353be6
Clean up as per the linter.
rsartor-cmd Jun 30, 2026
ee6395d
Remove print()s per buildifier.
rsartor-cmd Jun 30, 2026
8d80783
Remove unused variable (buildifier).
rsartor-cmd Jun 30, 2026
451ea48
Sort keys [buildifier]
rsartor-cmd Jun 30, 2026
a40ae2b
Remove print()s per buildifier.
rsartor-cmd Jun 30, 2026
90ad765
Remove unused load().
rsartor-cmd Jun 30, 2026
708dac4
Call out unused parameters [buildifier]
rsartor-cmd Jun 30, 2026
830723f
Add some basic tests of different dependency situations, so we can co…
rsartor-cmd Jul 6, 2026
37f5eaa
Replace the custom compiling and linking logic with internal cc_libra…
rsartor-cmd Jul 6, 2026
4596ae2
Add missing files.
rsartor-cmd Jul 6, 2026
933f69f
Add a data argument to the macro.
rsartor-cmd Jul 6, 2026
6f05ae0
Add missing file
rsartor-cmd Jul 7, 2026
8f2fa54
Add a couple more examples for PyInit_* defined in dependency targets.
rsartor-cmd Jul 7, 2026
908ccd5
Add missing files
rsartor-cmd Jul 7, 2026
eb4b8a8
Expand the analysis tests with more details assertions.
rsartor-cmd Jul 7, 2026
12bc59e
Re-format files
rsartor-cmd Jul 7, 2026
b158975
Address buildifier and buildifier-lint warnings.
rsartor-cmd Jul 7, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
99 changes: 81 additions & 18 deletions python/private/cc/py_extension_macro.bzl
Original file line number Diff line number Diff line change
@@ -1,33 +1,96 @@
"""Wrapper macro for the py_extension rule."""
"""Macro for creating Python extensions."""

load("@rules_cc//cc:cc_library.bzl", "cc_library")
load("@rules_cc//cc:cc_shared_library.bzl", "cc_shared_library")
load("//python/private:util.bzl", "add_tag")
load(
":py_extension_rule.bzl",
_py_extension = "py_extension",
##_py_extension_csl_rule = "py_extension_csl",
)
load(":py_extension_rule.bzl", "py_extension_wrapper")

def py_extension(**kwargs):
"""A macro that calls the py_extension rule and adds a tag.
def py_extension(
name,
srcs = None,
hdrs = None,
copts = None,
defines = None,
deps = None,
dynamic_deps = None,
exports_filter = None,
user_link_flags = None,
visibility = None,
data = None,
**kwargs):
"""Creates a Python extension module.

Args:
**kwargs: Additional arguments to pass to the rule.
name: Target name.
srcs: Optional C/C++ source files to compile directly for this extension.
hdrs: Optional header files for the srcs.
copts: Optional compiler flags for srcs.
defines: Optional preprocessor defines for srcs.
deps: cc_library targets to statically link into the extension.
dynamic_deps: cc_shared_library targets to dynamically link.
exports_filter: Filter for exported symbols passed to cc_shared_library.
user_link_flags: Additional link flags passed to cc_shared_library.
visibility: Target visibility.
data: Optional list of files or targets needed by this extension at runtime.
**kwargs: Additional arguments passed to the underlying wrapper rule.
"""
add_tag(kwargs, "@rules_python//python/cc:py_extension")

use_csl = kwargs.pop("use_csl", False)
if use_csl:
_py_extension_csl(**kwargs)
else:
_py_extension(**kwargs)
csl_deps = []

def _py_extension_csl(*, name, module_name = None, **kwargs):
if not module_name:
module_name = name
# 1. Handle user-supplied static deps
if deps:
csl_deps.extend(deps)

# 2. If srcs or hdrs are specified, create an implicit cc_library for them
if srcs or hdrs:
impl_lib_name = "_" + name + "_impl"
cc_library(
name = impl_lib_name,
srcs = srcs,
hdrs = hdrs,
copts = (copts or []) + ["-fPIC"],
defines = defines,
deps = ["@rules_python//python/cc:current_py_cc_headers"],
visibility = ["//visibility:private"],
)
csl_deps.append(":" + impl_lib_name)

# 3. If no static deps or sources were specified, use empty target for CSL requirement
if not csl_deps:
csl_deps.append("//python/private/cc:empty")

# 4. Create the underlying cc_shared_library
csl_name = "_" + name + "_csl"
csl_kwargs = {}
if exports_filter:
csl_kwargs["exports_filter"] = exports_filter
if user_link_flags:
csl_kwargs["user_link_flags"] = user_link_flags

cc_shared_library(
name = csl_name,
deps = csl_deps,
dynamic_deps = dynamic_deps,
visibility = ["//visibility:private"],
**csl_kwargs
)

# 5. Select default libc constraint if not provided
if "libc" not in kwargs:
kwargs["libc"] = select({
"@rules_python//python/config_settings:_is_py_linux_libc_glibc": "glibc",
"@rules_python//python/config_settings:_is_py_linux_libc_musl": "musl",
"//conditions:default": "glibc",
})

if data != None:
kwargs["data"] = data

# 6. Wrap with py_extension_wrapper for PEP 3149 naming & PyInfo
py_extension_wrapper(
name = name,
shared_lib_name = module_name + ".so",
src = ":" + csl_name,
visibility = visibility,
**kwargs
)
Loading
Loading