chore(release): allow comments to trigger actions, update releasing docs#3891
Merged
Conversation
Updates the release documentation to reflect the new process using the Release Tracking Issue, comments (/prepare, /create-rc, /process-backports), and automated workflows.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the release documentation in RELEASING.md to reflect a new semi-automated release process centered around a GitHub Release Tracking Issue and automated workflows. The feedback points out a broken markdown link reference [Patch release with cherry picks] that needs to be updated with an explicit anchor target.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Clarifies that the tracking issue is created automatically by the Prepare workflow, and that the release branch is cut automatically after the prepare PR is merged.
- Add workflow_call trigger to release_promote_rc.yaml. - Update on_issue_comment.yaml to parse /promote and /finalize commands, extract version from issue title, and trigger release_promote_rc.yaml. - Document the new commands in release_tracking_template.md. - Restructure RELEASING.md steps to match the 6-step release process.
- Only support /promote command (remove /finalize). - Pass issue number to release_promote_rc.yaml from on_issue_comment.yaml. - Document /promote in release tracking template. - Update RELEASING.md: - Add maintainer and newline requirements note. - Link to Release: Prepare workflow and provide `gh` CLI command. - Add "How to add backports" section and link to it.
- Update promote_rc.py to resolve version from issue title if not provided. - Simplify on_issue_comment.yaml by removing version parsing. - Update release_promote_rc.yaml to make version optional and pass issue. - Simplify release_tracking_template.md, moving details to RELEASING.md. - Update RELEASING.md: - Add Manual Editing section. - Expand backports section with failure details. - Use GitHub alert syntax for notes. - Add --repo flag to gh command.
- Add `add-backports` subcommand to release tool, which adds PRs to the tracking issue checklist and then processes backports. - Register `AddBackports` in release.py. - Add `add_backports_to_body` helper to release_issue.py. - Update release_process_backports.yaml to accept optional `add_backports` input and conditionally run `add-backports` or `process-backports`. - Update on_issue_comment.yaml to parse `/add-backports` comment command and trigger the workflow with `add_backports` input. - Document `/add-backports` in release tracking template. - Document `/add-backports` in RELEASING.md, and refine backports failure documentation.
- Remove add-backports subcommand; merge its functionality into process-backports as --add flag. - Update release_process_backports.yaml to use process-backports --add. - Update on_issue_comment.yaml: - Add GH_TOKEN to Parse comment step. - Add thumbs-down reaction on empty PR list for /add-backports. - Remove trailing empty line. - Update promote_rc.py to verify RC tag commit matches release branch head, updating "Tag Final" task to error status on mismatch. - Update RELEASING.md: - Refine terminology and formatting. - Update release_tracking_template.md: - Add 1-sentence explanations to commands.
- Update release_tracking_template.md: Shorten descriptions for `/prepare` and `/create-rc`, and update `/add-backports` terminology. - Update release_process_backports.yaml: Inline constant argument values and pass `add_backports` value as-is. - Update process_backports.py: - Change `--add` argument type to `str` to accept comma/space-separated PRs. - Parse the `--add` string (allowing '#' prefix) in the `run` method. - Update promote_rc.py: Use `error-rc-tag-not-branch-head` status and `tag_commit` key. - Update release_issue.py: Support space-after-equals formatting for any key ending with `_commit` in `format_metadata_line` to enable GitHub autolinking.
- Move `--add` argument parsing logic into `parse_pr_list` helper in `utils.py`, using it as a type validator in argparse. - Simplify `process_backports.py` to use `parse_pr_list` and remove inline parsing. - Update `release_process_backports.yaml` to format `--add` as `--add=value`.
- Add `add_comment_reaction` method to `GitHub` helper class. - Add `--triggering-comment` flag to `process-backports` subcommand. - Refactor `ProcessBackports.run` to capture all failures and react with thumbs-down to the triggering comment if the flag is provided. - Update `release_process_backports.yaml` to accept optional `comment_id` input and pass it to the release tool. - Update `on_issue_comment.yaml` to pass the triggering comment ID to the backports workflow.
- Define `GH_REACTION_THUMBS_DOWN` and other reaction constants in `gh.py`. - Update `process_backports.py` to use `GH_REACTION_THUMBS_DOWN` instead of literal `"-1"`.
- Update `process_backports_test.py` and `promote_rc_test.py` to use `argparse.Namespace` for arguments to avoid mock truthiness issues. - Fix assertions in `promote_rc_test.py` to account for the new release branch head verification (additional fetch and get_commit_sha calls). - Rename `test_promote_rc_defaults_to_determine_next_version` to `test_promote_rc_resolves_version_from_issue` and mock issue title resolution.
rickeylev
changed the title
rickeylev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the release documentation to reflect the new process using
the Release Tracking Issue, comments (/prepare, /create-rc, /process-backports),
and automated workflows.