chore(release): auto-add RC tasks to checklist in create-rc#3894
Conversation
- Add `add_rc_task_to_body` to `release_issue.py` to dynamically insert new `Tag RC<N>` tasks into the checklist before `Tag Final`. - Modify `create_rc.py` to detect if the next RC task is missing from the checklist, and if so, auto-add it and update the tracking issue body before proceeding. - Add `test_create_rc_auto_add_task` to `create_rc_test.py` to verify this behavior.
rickeylev
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces functionality to automatically append a missing 'Tag RC' task to the release checklist issue body if it is not already present. The review feedback highlights a potential indexing bug in add_rc_task_to_body that could incorrectly raise a ValueError when 'Tag Final' is the first metadata line. Additionally, the reviewer suggests optimizing GitHub API usage by updating the issue body once instead of twice, and updating the unit tests to reflect this change.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
- Modify `process_backports.py` to check if a pending RC task exists when backports are added. - If no pending RC task exists, auto-add the next `Tag RC<N>` task to the checklist. - Add `test_process_backports_add_backports_and_auto_add_rc_task` to `process_backports_test.py` to verify this behavior.
1 participant
Modify create-rc subcommand to automatically insert missing Tag RC tasks into the tracking issue checklist before Tag Final, rather than failing.