tests: convert private tool tests to pytest_test and pytest style#3945
Open
rickeylev wants to merge 2 commits into
Open
tests: convert private tool tests to pytest_test and pytest style#3945rickeylev wants to merge 2 commits into
rickeylev wants to merge 2 commits into
Conversation
Convert private tool tests (tests/tools/zipapp/ and tools/private/update_deps/) to pytest_test and pytest style to be more idiomatic Python tests. Also converts to use pytest fixtures.
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Collaborator
Author
|
/review |
Collaborator
Author
|
Nothing notable about using pytest rules in this |
Set target_compatible_with = SUPPORTS_BZLMOD on private tool pytest_test targets to prevent ModuleNotFoundError: No module named 'pytest_bazel' in non-bzlmod CI test matrix runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert private tool tests (
tests/tools/zipapp/andtools/private/update_deps/) topytest_testand pytest style tobe more idiomatic Python tests.
Also converts to use pytest fixtures.