Update rust_stdlib_filegroup to detect profiler_builtins#3958
Merged
UebelAndre merged 2 commits intobazelbuild:mainfrom Apr 16, 2026
Merged
Update rust_stdlib_filegroup to detect profiler_builtins#3958UebelAndre merged 2 commits intobazelbuild:mainfrom
rust_stdlib_filegroup to detect profiler_builtins#3958UebelAndre merged 2 commits intobazelbuild:mainfrom
Conversation
UebelAndre
changed the title
rust_stdlib_filegroup to detect profiler-builtinsrust_stdlib_filegroup to detect profiler_builtins
Collaborator
Author
|
Friendly ping @krasimirgg |
krasimirgg
approved these changes
Apr 16, 2026
Collaborator
krasimirgg
left a comment
krasimirgg
left a comment
There was a problem hiding this comment.
Thank you! Looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a
coverage_enabledtorust_toolchainthat should be used to identify if the toolchain supports coverage. This would allow repositories which use MUSL to runbazel coverage //...without running into a linker error. The downside is that they will get no coverage but this would already be the case due to the linker error. More details on rust-lang/rust#79556