Add unstable_rust_features attribute#3963
Open
FabianWolff wants to merge 2 commits intobazelbuild:mainfrom
Open
Add unstable_rust_features attribute#3963FabianWolff wants to merge 2 commits intobazelbuild:mainfrom
unstable_rust_features attribute#3963FabianWolff wants to merge 2 commits intobazelbuild:mainfrom
Conversation
968751a to
48e46b3
Compare
krasimirgg
reviewed
Apr 16, 2026
Collaborator
krasimirgg
left a comment
There was a problem hiding this comment.
Let's add some tests. Since this requires nightly, testing is a bit awkward:
- You define a new "integration test" that itself has a top-level
MODULE.bazelfile where you register a nightly toolchain. - Then you update the continuous testing definitions to add a new environment that uses that.
- The results should immediately show up in CI testing results for the PR.
b5218ab to
8bb1119
Compare
krasimirgg
reviewed
Apr 16, 2026
5c1c197 to
63e4702
Compare
krasimirgg
reviewed
Apr 16, 2026
63e4702 to
4440bb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attribute can be set to the label of a target that provides
UnstableRustFeaturesInfo, which maps a label to a set of unstable features allowed for that label. The intent is to provide a way to centrally manage the use of unstable features, without having to use-Zallow-features=manually inrustc_flagsfor every affected target.