Pass all environment variables to vendoring#3964
Merged
UebelAndre merged 2 commits intobazelbuild:mainfrom Apr 16, 2026
Merged
Conversation
patrickmscott
force-pushed
the
patrick/crates-vendor
branch
4 times, most recently
from
1a507c6 to
862c070
Compare
I have been struggling for a long time with getting private registries and git repositories to work with vendoring. CARGO_REGISTR* is currently broken due to a typo. Private git repositories don't work because the ssh auth socket is not forwarded. And custom .ssh/config blow up if all env variables referenced in the config are not forwarded. There is no great way to forward all the right environment variables. This does not appear to affect repinning directly in bzlmod. Explicitly remove OUTPUT_BASE which is set in CI.
patrickmscott
force-pushed
the
patrick/crates-vendor
branch
from
862c070 to
db4490b
Compare
UebelAndre
approved these changes
Apr 16, 2026
Collaborator
UebelAndre
left a comment
UebelAndre
left a comment
There was a problem hiding this comment.
Since we can't or don't strip environment on windows, I suppose it's fair to relax the restriction on unix systems. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been struggling for a long time with getting private registries and git repositories to work with vendoring. CARGO_REGISTR* is currently broken due to a typo. Private git repositories don't work because the ssh auth socket is not forwarded. And custom .ssh/config blow up if all env variables referenced in the config are not forwarded.
There is no great way to forward all the right environment variables. This does not appear to affect repinning directly in bzlmod.