cargo-bazel: fix binary targets of proc-macro crates using wrong dep attribute#3975
Open
lamcw wants to merge 2 commits intobazelbuild:mainfrom
Open
cargo-bazel: fix binary targets of proc-macro crates using wrong dep attribute#3975lamcw wants to merge 2 commits intobazelbuild:mainfrom
lamcw wants to merge 2 commits intobazelbuild:mainfrom
Conversation
…attribute Problem: When a crate has both a rust_proc_macro library target and rust_binary targets (e.g. development utilities shipped alongside the proc-macro), make_rust_binary unconditionally places the library in `deps`. However, rules_rust validates that proc-macro libraries must appear in `proc_macro_deps`, not `deps`. This causes analysis failures for any such crate. Solution: In make_rust_binary, detect whether the crate's library target is a proc-macro by checking if Rule::ProcMacro(_) is present in krate.targets. If it is, insert the library label into proc_macro_deps instead of deps. Testing: - binary_of_proc_macro_crate_uses_proc_macro_deps: verifies that the generated rust_binary has the proc-macro lib in proc_macro_deps and not in deps.
Signed-off-by: Thomas Lam <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a crate has both a
rust_proc_macrolibrary target andrust_binarytargets (e.g. development utilities shipped alongside the proc-macro),make_rust_binaryunconditionally places the library indeps. However, rules_rust validates that proc-macro libraries must appear inproc_macro_deps, notdeps. This causes analysis failures for any such crate.Solution
In
make_rust_binary, detect whether the crate's library target is a proc-macro by checking ifRule::ProcMacro(_)is present inkrate.targets. If it is, insert the library label intoproc_macro_depsinstead ofdeps.Testing
binary_of_proc_macro_crate_uses_proc_macro_deps: verifies that the generatedrust_binaryhas theproc-macro lib inproc_macro_depsand not indeps.