Expand the Testing section with practical guidelines#272
Merged
Conversation
Add six new rules: use testing blocks for context, informative assertion messages, are for tabular tests, one concept per deftest, use with-redefs sparingly, and test expected exceptions. Brings the section from 3 to 9 rules.
bbatsov
force-pushed
the
expand-testing-section
branch
from
8439983 to
6d83c1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Testing section had only 3 rules covering naming and directory structure — nothing about how to actually write good tests. This adds 6 new rules covering
testingblocks, assertion messages,arefor tabular tests, one-concept-per-deftest,with-redefsguidance, and exception testing withthrown?.