Open
Conversation
* removed test_default_toolset_requirements * removed test_conditions_on_default_toolset * added test_default_toolset for testing of build-system.set-default-toolset rule * optimized default-toolset selection in build-system.jam
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_default_toolset_requirements[1]test_conditions_on_default_toolset[2]test_default_toolsetfor testing ofbuild-system.set-default-toolsetrulebuild-system.jamNote
Do we really need
test/results-python.txt?[1]
test_default_toolset_requirementshas the following problems:feature.get-values, since it is not intended to process conditionals, and even if it were, it would not be correct to write one like the ones used in the test, i.e.:<description>toolset-requirement:<description>conditioned-requirementconsidering that "Free features can never be used in conditionals" as I found written in a comment inbuild/feature.jam(who knows if it's true... the test could have also avoided creating thedescriptionfeature and used the defaultdefine.)buildRuleused in thenotfile testTargettarget cannot see the properties set on the toolset with thetoolset.add-requirementsbecause the Jamfile is loaded before theusingof the default toolset is executed, i.e., before thetoolset.add-requirementsis called.[2]
The
test_conditions_on_default_toolsetis affected by the same issues as thetest_default_toolset_requirementsabove.