Conversation
Commit 64b0d68 "fix: module navbar colors" actually broke them! In light mode, full-width window (static sidebar) the sidebar links are white-on-white. I got a bit carried away with this one and - improved highlighting of the main section-name (i.e. header buttons) - fix color scheme of "dropdown" sidebar when window is narrow (it had been red background, etc.) - Add explanatory comments in custom.css to make it clear what visual element is affected. - Tweaked visibility of the light/dark toggle. That said, it is quite likely that there are "better" ways to do this, but trying "simple" things like adjusting IFM variables only worked some of the time...
|
Oh, and added thin bars above group headers to provide clearer separation |
the top navbar has some weird vertical alignment now. and Im not keen on the red on light grey, I am finding that hard to read I havent looked at the code, probably should later |
arikorn
force-pushed
the
fix_color_schemes
branch
from
0195997 to
b187580
Compare
|
Ah... well... I was trying to give the top bar a "tab-style" look, but clearly didn't do a very good job. I just pushed a better version, -- the alignment is fixed, but the overall effect is still not perfect, so if you don't like it maybe it should be ripped out? The color change for dark-mode active links was probably a mistake on my part, left over from some experimentation. It should be back to what it was now. |
|
I can't say that I love that look, but it looks natural/intentional now and I dont hate it. May as well merge it and see how I feel in a few weeks |
|
some of this probably wants porting to the companion build of the docs too, for consistency |
|
Yeah, to both (all 3) comments. I'm going to play with it a bit to, hopefully refine and/or simplify it a bit more, so might as well hold off on porting until then, at least. The ideal way to do it would be with shoulders at the bottom and maybe even change the color to match the window background like "real" tabs... Anyway, the good news is that it should be pretty easy to undo later. Actually, looking at Companion now, the light color scheme is pretty bad in the narrow-window sidebar. I can open a PR on that for sure. One thing that bugs me is that the light-dark-mode toggle goes into the sidebar when the window is narrow, which makes no sense to me -- there's plenty of room for it. Not sure if there's a simple fix or it's just baked in? |
2 participants
Commit 64b0d68 "fix: module navbar colors" actually broke them! In light mode, full-width window (static sidebar), the sidebar links are white-on-white.
I got a bit carried away with this one and
That said, it is quite likely that there are "better" ways to do this, but trying "simple" things like adjusting IFM variables only worked some of the time... Please consider all of my changes as "suggestions."