Fixed Script.fromASM support PUSHDATA

[baryon]

Script.fromASM should support PUSHDATA, otherwise it will lead to incorrect chunks settings, which in turn makes the result of toBuffer incorrect.

The bitcore-lib-cash code was previously fixed. LTC and DOGE are also incorrect, if corrections are needed, submit a patch separately.

[baryon]

The test results of CircleCI do not seem to be related to this commit.

 1 failing

  1) Coin Model
       should appropriately mark coins related to transactions that are in mempool, but no longer valid:

      AssertionError: expected -1 to equal -3
      + expected - actual

      --1
      +-3
      
      at Context.<anonymous> (test/integration/models/coin.spec.ts:123:38)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)

[kajoseph]

Thanks for the PR, @baryon ! I left some feedback on making it a little cleaner and consistent with the rest of the codebase.

Also, I won't be able to merge this in unless your commits are signed

[kajoseph]

For consistency and for linting, would you mind just copying the code from the bitcore-lib-cash script.js? Feel free to clean it up a little (don't need to re-declare opcodenum, for example), but your code here has some inconsistent formatting/linting with the rest of the codebase.

[kajoseph]

there is already a #fromASM describe in this file, and bitcore-lib-cash already has some pushdata tests. Would you please copy those tests to the existing #fromASM describe?

[baryon]

Fixed

[baryon]

In the cash code, a constant is calculated every time

bitcore/packages/bitcore-lib-cash/lib/script/script.js

Line 716 in d7d5182

} else if (len < Math.pow(2, 8)) {

, which is unnecessary. In my code, the value of the constant is explicitly stated. Additionally, cash does not provide test cases for this part of the code.

[kajoseph]

In the cash code, a constant is calculated every time

bitcore/packages/bitcore-lib-cash/lib/script/script.js

Line 716 in d7d5182

} else if (len < Math.pow(2, 8)) {

, which is unnecessary. In my code, the value of the constant is explicitly stated. Additionally, cash does not provide test cases for this part of the code.

Constants are fine - I agree that your constants are better than the computed values in BCH lib. I was more noticing the linting. You have inconsistent spacing around the braces and we're trying to move away from using lodash (_), so opcodenum == null or (opcodenum === undefined if null is a valid value) is more preferable over _.isUndefined(opcodenum)

There are 3 PUSHDATA tests in the BCH lib that are relevant to this codeblock, but your additional test is welcome.

Lastly, all of your commits need to be signed, so you'll need to squash all your commits into a new one and force push.