Simplify agents and teams cards#1199
Conversation
klopez4212
force-pushed
the
kennylopez-agents-page-cards
branch
from
9b87d11 to
60822a4
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60822a4471
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
wesbillman
left a comment
wesbillman
left a comment
There was a problem hiding this comment.
Thanks for simplifying the card layout. I found a blocker in the refactor: the local-agent View logs action is still present, but the new card UI no longer renders the selected log panel. I also noticed team descriptions are still passed into the card component but are no longer surfaced.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69263345d5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c68994e4f4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
klopez4212
force-pushed
the
kennylopez-agents-page-cards
branch
from
aab3f93 to
b6ebac0
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b6ebac07bb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Heads-up, Kenny 👋 — flagging some in-flight work that builds on top of this branch so you're not surprised by it. We're adding a "Save as persona template" action for managed agents (UX consistency work, IXI #1201 line). Because your PR rewrites the exact surface it touches — the agent action menus moving into the card Scope is deliberately small and additive:
We are NOT touching It'll come up shortly as a draft PR targeting this branch ( |
|
Draft PR is up → #1301 (targets this branch, |
…tecture Resolves the conflict in UnifiedAgentsSection.tsx between #1199's card-grid simplification and main's #1274 move of agent/persona management into the profile sidebar. Keeps the identity-card grid layout and drives every interaction through onOpenAgentProfile/onOpenPersonaProfile; drops the now-orphaned per-card action dropdowns whose handlers main removed from AgentsView. Inline log panel, model picker, and lastError affordances preserved. Updates the mesh-compute e2e helper to open the profile panel via card click instead of the removed Manage button. Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
The card-grid layout replaces the Manage button with a clickable identity card, so the agent-lifecycle helper now opens the profile panel by clicking the card's 'agent profile' button. Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
3 participants
Summary
Notes
Validation
cd desktop && pnpm checkcd desktop && pnpm typecheckgit diff --check