Show plan types in UI + fix tags column removal#82
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4781811864
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| has_many :notifications, dependent: :destroy | ||
|
|
||
| after_initialize { self.tags ||= [] } | ||
| after_initialize { self.metadata ||= {} } |
There was a problem hiding this comment.
Keep tags default until tags field is fully removed
Dropping the tags initializer here changes newly created plans from tags: [] to tags: null while the rest of the app still treats tags as a live field (the schema still has coplan_plans.tags, and the API continues to read/write tags). In practice, a client that creates a plan without sending tags now gets a nullable shape instead of an array and can break if it assumes iterable tags based on the documented/update contract. Keep the default ([]) in place until the column and API exposure are removed together.
Useful? React with 👍 / 👎.
4781811 to
1779697
Compare
- Add plan type badge to plan cards on homepage - Add plan type badge to plan show page header - Add plan type filter pills on homepage - Remove stale tags after_initialize (column was dropped by tag model migration) - Add badge--type CSS style
1779697 to
90538c6
Compare
|
Re: Codex review on |
Makes plan types visible end-to-end:
after_initialize { self.tags ||= [] }since thetagscolumn was dropped by the tag model migration