Conversation
- Add user_avatar helper that renders avatar_url images or initial fallbacks - Show avatars on plan cards (index) and plan detail header - Show avatar images in the active viewers list when avatar_url is set - Show avatars next to comment authors - Add .avatar CSS component with sm/md sizes - Seed demo users with avatar_url, title, and team fields Amp-Thread-ID: https://ampcode.com/threads/T-019d6373-a857-75b8-b976-dc9a989c53e0 Co-authored-by: Amp <[email protected]>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e7052aae44
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| user_name ||= if comment.author_type == "cloud_persona" | ||
| AutomatedPlanReviewer.find_by(id: comment.author_id)&.name || "Reviewer" | ||
| else | ||
| comment.author_type | ||
| end |
There was a problem hiding this comment.
Restore user-friendly fallback author labels
This fallback now returns raw author_type values when the backing user lookup fails, so historical comments can render internal enum strings like human or local_agent (for example, after a user is removed in ActiveAdmin or related token rows are gone). That is a regression from the previous Unknown/Agent behavior and produces confusing thread headers such as bot-name (via local_agent); keep explicit human-readable fallbacks per author type.
Useful? React with 👍 / 👎.
Summary
Shows user avatars (or initial fallbacks) on plan cards, plan headers, active viewers, and comment threads.
Changes
user_avatarhelper — Renders<img>whenavatar_urlis set, falls back to initials in a colored circle.avatarcomponent withsm/mdsizes,object-fit: coveron viewer imagesTo test locally