Repository navigation
Send identity when querying comdb2db too - #6061
Conversation
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_resume_logicalsc_generated **quarantined**
consumer_non_atomic_default_consumer_generated **quarantined**
sc_downgrade [timeout] **quarantined**
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
analyze_exit_immediately [failed with core dumped]
cdb2api_rollback_rc [failed with core dumped]
reco-ddlk-sql **quarantined**
consumer_non_atomic_default_consumer_generated **quarantined**
sc_downgrade [timeout] **quarantined**
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
sp_snapshot_generated
consumer_non_atomic_default_consumer_generated **quarantined**
sc_downgrade [timeout] **quarantined**
truncatesc_offline_generated [timeout] **quarantined**
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated **quarantined**
sc_downgrade [timeout] **quarantined**
d95807a to
036eaf7
Compare
Signed-off-by: mkhullar <mohit.khullar@gmail.com>
036eaf7 to
53a1b1a
Compare
| flags |= CDB2_USE_OPTIONAL_IDENTITY; | ||
| if (cdb2_non_threaded_identity) | ||
| flags |= CDB2_NON_THREADED_IDENTITY; | ||
| id_blob = identity_cb->getIdentity(hndl, flags); |
There was a problem hiding this comment.
Does this account for hndl being NULL?
There was a problem hiding this comment.
Yes, cdb2_getIdentity checks for hndl's identity only in the case its not NULL.
There was a problem hiding this comment.
Got it. I guess for fdb queries this would use the server identity instead of the client identity here? And we can't cache identity here.
There was a problem hiding this comment.
Yes, it will send server's identity for fdb queries. Server's/Task's identity remains same until refresh (which usually happens every 60 seconds).
|
Thanks |
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
constraints_noreorder_generated [failed with core dumped]
constraints [failed with core dumped]
nowritetimeout
constraints_partial_index_off_generated
sqlqueries
snapshot_during_truncate **quarantined**
reco-ddlk-sql [timeout] **quarantined**
skipscan [timeout] **quarantined**
hndlargbegincdb2_run_statement_typed_intcomdb2db_get_dbhosts(discovery)