Skip to content

Fix Math.acosh test for i686 architectures#5389

Merged
hansl merged 1 commit into
boa-dev:mainfrom
jedel1043:fix-math-acosh-test
May 31, 2026
Merged

Fix Math.acosh test for i686 architectures#5389
hansl merged 1 commit into
boa-dev:mainfrom
jedel1043:fix-math-acosh-test

Conversation

@jedel1043
Copy link
Copy Markdown
Member

This fixes our CI that is currently failing.

@jedel1043 jedel1043 requested a review from a team as a code owner May 30, 2026 22:41
@github-actions github-actions Bot added Waiting On Review Waiting on reviews from the maintainers C-Tests Issues and PRs related to the tests. C-Builtins PRs and Issues related to builtins/intrinsics and removed Waiting On Review Waiting on reviews from the maintainers labels May 30, 2026
@github-actions github-actions Bot added this to the v1.0.0 milestone May 30, 2026
@github-actions
Copy link
Copy Markdown

Test262 conformance changes

Test result main count PR count difference
Total 53,125 53,125 0
Passed 51,071 51,072 +1
Ignored 1,482 1,482 0
Failed 572 571 -1
Panics 0 0 0
Conformance 96.13% 96.14% +0.00%
Fixed tests (1):
test/staging/sm/Math/acosh-approx.js (previously Failed)

Tested main commit: 8f5ef6542d641fd22320e51234e914b59e623717
Tested PR commit: 732f82e0a853af6d417630c22a804077110810f4
Compare commits: 8f5ef65...732f82e

@codecov
Copy link
Copy Markdown

codecov Bot commented May 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.11%. Comparing base (6ddc2b4) to head (732f82e).
⚠️ Report is 967 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5389       +/-   ##
===========================================
+ Coverage   47.24%   60.11%   +12.87%     
===========================================
  Files         476      566       +90     
  Lines       46892    63024    +16132     
===========================================
+ Hits        22154    37890    +15736     
- Misses      24738    25134      +396     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hansl hansl added this pull request to the merge queue May 31, 2026
Merged via the queue into boa-dev:main with commit 06b3a45 May 31, 2026
22 checks passed
@jedel1043 jedel1043 deleted the fix-math-acosh-test branch May 31, 2026 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Builtins PRs and Issues related to builtins/intrinsics C-Tests Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants