feat(core, prompts): add async autocomplete options - #471
Conversation
|
11b7529 to
ebd1852
Compare
commit: |
|
this is a very large change for something we haven't seen much demand for. also note that this doesn't fix #467, it just adds async on top of what that is asking to document. i very much appreciate the work that has gone into this, but am tempted to leave it sync-only until we see some real demand for it. otherwise it is a slippery slope to introducing a lot of extra code for edge case features. @dreyfus92 thoughts? |
|
i agree. i'd rather keep it as it is until we see a real demand, this is a lot of surface for an edge case. a couple of things for context: #467 is asing for a reordering filter, not async, and that's already doable with the options getter reading |
This PR enhances the autocomplete prompt to support async option functions.
Fixes:
#467
What’s New:
Autocomplete:
Common/Helper:
unicodeOris now genericisAsyncfunction was added.Backwards Compatibility:
Notes:
This PR has the feature itself fully developed. I didn't create any unit tests yet since I want to get feedback on my implementation. When I get an thumbs up on the implementation I'll add the unit tests / examples and remaining files.