fix(prompts): calculate multi-select vertical offsets using post-wrapped line counts#577
Open
HarshalPatel1972 wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 62ce5a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gameroman
requested changes
Jun 26, 2026
gameroman
left a comment
gameroman
left a comment
Member
There was a problem hiding this comment.
Is there a related issue?
If this is a bug fix, we need tests
Please fill in the pull request template fully and do not remove any sections
commit: |
dreyfus92
reviewed
Jun 26, 2026
Member
There was a problem hiding this comment.
hey @HarshalPatel1972, thank you for taking the time in working with this but please follow the PR template provided rather than whatever your agent outputs:
https://github.com/bombshell-dev/clack/blob/main/.github/PULL_REQUEST_TEMPLATE.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR corrects a terminal rendering bug in the
MultiSelectPromptwhere multi-line choices containing wrapped description strings caused terminal cursor line-tracking offsets to miscalculate. By forcing vertical layout boundaries to evaluate height metrics directly from post-wrapped line array lengths rather than raw element counts, the terminal layout accurately positions the cursor and prevents option text from visually overwriting itself on smaller displays.Closes #
Type of change
Checklist