Repository navigation
feat: input parser probe-response recognition → CapabilityEvent #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
08779ef
feat: input parser recognizes probe responses (input-spec §6)
natemoo-re aeb96df
feat: createInput({ detection }) surfaces CapabilityEvents from scan()
natemoo-re be4bcec
chore: add changeset
bombshell-cooper[bot] 453f218
Update .changeset/cooper-approved-132.md
natemoo-re 482d212
refactor!: keep createInput({ terminfo }), now taking a Detection
natemoo-re 5081cb4
refactor!: rename Detection to TerminalInfo, raw bytes to `entry`
natemoo-re cac4006
spec(terminfo): detectTerminal rejects only on oversized `entry`
natemoo-re 0d1f019
spec(terminfo): keep MAX_TERMINFO_ENTRY size on one line
natemoo-re File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| --- | ||
|
natemoo-re marked this conversation as resolved.
|
||
| "@bomb.sh/tty": minor | ||
| --- | ||
|
|
||
| Adds `CapabilityEvent` to `InputEvent` and changes `InputOptions.terminfo` to accept a `TerminalInfo`. | ||
|
|
||
| `scan()` now parses terminal probe responses — OSC 10/11/12 theme colors, OSC 21 kitty color protocol, OSC 22 pointer shape, XTGETTCAP (`DCS`), kitty graphics (`APC`), kitty keyboard (`CSI ?…u`), synchronized output (`DECRPM`), and DA1 — and surfaces them as typed `CapabilityEvent` objects with keys `foreground-color`, `background-color`, `cursor-color`, `colordepth`, `sync-output`, `kitty-keyboard`, `kitty-graphics`, and `pointer-shape`. | ||
|
|
||
| **Breaking:** `InputOptions.terminfo` now takes the `TerminalInfo` returned by `detectTerminal()` instead of raw compiled terminfo bytes. It seeds the key-sequence trie from `terminfo.keys` and uses `terminfo.capabilities.colors` to resolve colordepth denial events to the correct tier (`"16"` vs `"256"`). Raw bytes now go to `detectTerminal({ entry })`. | ||
|
|
||
| #### Migration | ||
|
|
||
| ```diff | ||
| - import { createInput } from "@bomb.sh/tty"; | ||
| + import { createInput, detectTerminal } from "@bomb.sh/tty"; | ||
|
|
||
| - const input = await createInput({ terminfo: myTerminfoBinary }); | ||
| + const terminfo = await detectTerminal({ env: process.env, entry: myTerminfoBinary }); | ||
| + const input = await createInput({ terminfo }); | ||
| ``` | ||
|
|
||
| Omit `terminfo` entirely to keep the xterm default key sequences. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changeset needs revision.
Changeset package scope does not match the affected packages confidently. Changeset bump does not match the consumer-visible impact.
View the proposed replacement