Skip to content

volley_punch#462

Merged
vishal332008 merged 5 commits into
bombsquad-community:mainfrom
Scriptz1:main
Jun 1, 2026
Merged

volley_punch#462
vishal332008 merged 5 commits into
bombsquad-community:mainfrom
Scriptz1:main

Conversation

@Scriptz1

@Scriptz1 Scriptz1 commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

A fully immersive mod for BombSquad.

@Scriptz1 Scriptz1 changed the title VolleyPunch volley_punch Jun 1, 2026
@vishal332008 vishal332008 merged commit f6c0fd5 into bombsquad-community:main Jun 1, 2026
@Loup-Garou911XD

Copy link
Copy Markdown
Member

@vishal332008 did you rebase the merge...??

@vishal332008

Copy link
Copy Markdown
Member

@Loup-Garou911XD i squash merged it...

@Loup-Garou911XD

Copy link
Copy Markdown
Member

@Loup-Garou911XD i squash merged it...

🤦

@Loup-Garou911XD

Copy link
Copy Markdown
Member

@Loup-Garou911XD i squash merged it...

and now u have broken stuff
the utilities.json stores commit sha to keep track of the exact file version, squashing will remove that commit from the history

And then the sha in utilities.json would be pointing to an invaild commit that doesnt exist

@vishal332008

Copy link
Copy Markdown
Member

@Loup-Garou911XD i squash merged it...

🤦

Come on man, I'm trying, how am I supposed to know this CI thing will run for squash merged too, sorry

@Loup-Garou911XD

Copy link
Copy Markdown
Member

@Loup-Garou911XD i squash merged it...

🤦

Come on man, I'm trying, how am I supposed to know this CI thing will run for squash merged too, sorry

ahh its okay

@Loup-Garou911XD

Copy link
Copy Markdown
Member

@Scriptz1 can you please create another pr, we kinda messed up
sorry

@vishal332008

Copy link
Copy Markdown
Member

@Loup-Garou911XD what's wrong with it tho, only CI failing, it'll fix itself the next commit

@vishal332008

Copy link
Copy Markdown
Member

It checked for a squash merge and messed itself up, but next time you accept a new plugin, just do normal merge and it'll be fixed, why another pr

@Loup-Garou911XD

Copy link
Copy Markdown
Member

@Loup-Garou911XD what's wrong with it tho, only CI failing, it'll fix itself the next commit

It will not, and the plugin won't be downloadable in the game

@vishal332008

Copy link
Copy Markdown
Member

@Loup-Garou911XD what's wrong with it tho, only CI failing, it'll fix itself the next commit

It will not, and the plugin won't be downloadable in the game

Wait, is it not working rn?

@Loup-Garou911XD

Copy link
Copy Markdown
Member

@Loup-Garou911XD what's wrong with it tho, only CI failing, it'll fix itself the next commit

It will not, and the plugin won't be downloadable in the game

Wait, is it not working rn?

I reverted the merge

@vishal332008

Copy link
Copy Markdown
Member

@Loup-Garou911XD what's wrong with it tho, only CI failing, it'll fix itself the next commit

It will not, and the plugin won't be downloadable in the game

Wait, is it not working rn?

I reverted the merge

Why 😭😭

@vishal332008

Copy link
Copy Markdown
Member

@Loup-Garou911XD btw if Eric comes online, can you tell him to check the PR i made? Please, and can you also see if there is any mistake or if there is any way I can fix the CI there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants