Draft
Conversation
59e022d to
bc6990d
Compare
This is the first part of a bigger refactoring. I tried to make it as non-intrusive as possible, so it's not ideal. But it will simplify the review, since this should have the same behavior/mistakes than the previous version. The current architecture of having all the actions as methods of a VM object, and storing the config of the disk image, VM, and the running Vm in s single json, is very inflexible. In addition, the cache logic is all over the place, so let's start with a simple cache implementation, that will allow us to move to the final goal. Signed-off-by: German Maglione <gmaglione@redhat.com>
bc6990d to
b4a8009
Compare
Collaborator
Author
|
@sourcery-ai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first part of a larger refactor. We have some issues that need to be fixed:
I'm marking this PR as draft because depends on PR #56