tests: corrupt manifest off-centre to fix flaky check --repair rebuild test on Windows#9827
Merged
ThomasWaldmann merged 1 commit intoJun 28, 2026
Conversation
…d test on Windows
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9827 +/- ##
==========================================
- Coverage 85.23% 85.18% -0.05%
==========================================
Files 92 92
Lines 15297 15303 +6
Branches 2299 2300 +1
==========================================
- Hits 13038 13036 -2
- Misses 1570 1578 +8
Partials 689 689 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_manifest_rebuild_corrupted_chunkcorrupted the manifest at a fixed offset of 250 bytes. A repository layout change moved that byte outside the encrypted manifest data on Windows, socheck --repairno longer hit the rebuild path and the test failed on the Windows Canary job. Corrupting atlen(manifest)//3puts the byte back inside the payload. The test passes locally for the local and remote variants.