-
Notifications
You must be signed in to change notification settings - Fork 104
Options is_periodic_y function
#3175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Provides a variable "periodicY" that is 1 in the core and 0 outside.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
|
Maybe |
Calls mesh->periodicY internally
Extends FakeMesh to mock periodicY methods.
Include in table of values available to expressions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
ZedThree
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bendudson!
Test failure is unrelated
Provides a variable
is_periodic_ythat is 1 in the core and 0 outside.This at least partly addresses #3171 by allowing input functions that distinguish core and PF regions.
Includes tests and entry in manual.