Skip to content

Conversation

@bendudson
Copy link
Contributor

@bendudson bendudson commented Oct 3, 2025

Provides a variable is_periodic_y that is 1 in the core and 0 outside.

This at least partly addresses #3171 by allowing input functions that distinguish core and PF regions.

Includes tests and entry in manual.

bendudson and others added 2 commits October 3, 2025 09:39
Provides a variable "periodicY" that is 1 in the core and 0 outside.
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@ZedThree
Copy link
Member

ZedThree commented Nov 3, 2025

Maybe is_y_periodic?

bendudson and others added 4 commits December 29, 2025 10:27
Calls mesh->periodicY internally
Extends FakeMesh to mock periodicY methods.
Include in table of values available to expressions.
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Member

@ZedThree ZedThree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bendudson!

Test failure is unrelated

@ZedThree ZedThree changed the title Options periodicY function Options is_periodic_y function Jan 6, 2026
@ZedThree ZedThree merged commit 4af5058 into next Jan 6, 2026
26 of 28 checks passed
@ZedThree ZedThree deleted the options_periodicY branch January 6, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants