Updates from brightdigit.com - #3
Merged
Merged
Conversation
Leaf Publish-stack packages had lint tooling but no workflows; mirror the Ink/Contribute leaf template (no path-dep rewrite needed). Co-authored-by: Cursor <cursoragent@cursor.com>
Files/Publish stack need iOS 18 / tvOS 18 / watchOS 11 for Synchronization.Mutex; ContributeRSS/WordPress declare iOS/tvOS 16 to match standalone CI deps. Co-authored-by: Cursor <cursoragent@cursor.com>
Publish stack (Files/Ink/Publish): - Move build-macos + build-macos-platforms off [self-hosted, macOS] to the GitHub-hosted xcode-27 runner (/Applications/Xcode_27.0.app, Swift 6.4-dev, 27.0 SDKs); add download-platform: true on the sim legs. - Files: remove the stale legacy Files.xcodeproj (schemes Files-iOS/-macOS/-tvOS shadowed swift-build's auto-calculated "Files" scheme) and the dead buddybuild_postbuild.sh, so xcodebuild resolves the SPM auto-scheme like Plot. - Ink: add iOS 18 / tvOS 18 / watchOS 11 platform floors for Synchronization.Mutex used in InkTests, mirroring Files. Lint: - TailwindKit: remove the superseded legacy 2022 Tailwind.* API (TailwindKit.swift's Tailwind struct + Flexbox/AspectRatio/Display/Breakpoints and their XCTest suites), exclude the Danger DSL script from SwiftLint; lint now clean (0 violations). - ReadingTimePublishPlugin: doc-comment public API, split test helpers into fixtures files, explicit ACL, rename ReadingTime.swift -> ReadingTimeMetadata.swift to satisfy file_name; lint clean, 8 XCTest tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Files hardcoded POSIX `/` separators while Foundation returns native `\` paths on Windows, producing broken hybrid paths (C:\Users\foo/.filesTest/, /C:/Users/foo/) and an internal inconsistency where makeParentPath rejoined URL.pathComponents with `/` so a folder's computed parent.path never string-== its stored path. Fix: store every path in canonical forward-slash form; keep all `/`-based internal logic; convert to native separators only at FileManager / URL(fileURLWithPath:) boundaries. New Sources/Path.swift adds String.canonicalizedPath / .nativePath / .isDriveRoot and Path.rootPath / .nativeSeparator, all no-ops off Windows (so macOS/Linux behavior is provably unchanged). makeParentPath preserves the Windows drive prefix (C:/Users/foo/ -> C:/Users/); `~` resolves via homeDirectoryForCurrentUser (drops a POSIX-only HOME force-unwrap); Folder.root is the current volume root on Windows. Tests stay XCTest: 3 assertions made platform-aware via a rootPath/canonical helper (no `#if` in test bodies), plus a filesystem-free PathTests suite exercising the separator + drive-prefix math on every platform. All 71 tests pass on macOS; lint clean (CI=1 LINT_MODE=STRICT). Pragmatic scope: UNC best-effort, == stays case-sensitive on all platforms. Windows CI is the ground truth. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
homeDirectoryForCurrentUser is unavailable on iOS/tvOS/watchOS, so the previous commit's ~ change broke the Apple-platform builds (which were green). NSHomeDirectory() is available on every Apple platform AND is platform-aware on Windows (resolves the user profile, not the POSIX-only HOME variable). Verified: iOS simulator build succeeds; 71/71 tests pass on macOS; lint clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.