Wave 0 review feedback: CI hygiene, fork attribution & agent tooling

[leogdion]

Applies Wave 0 review feedback to the brightdigit/Plot fork, and hardens the fork so John Sundell's original MIT attribution is preserved.

CI workflow (.github/workflows/Plot.yml)

• fail-fast: false → true on all four matrix legs (build-ubuntu, build-windows, build-macos-platforms, build-android)
• Ubuntu coverage: brightdigit/swift-coverage-action (SHA-pinned fork) → sersoft-gmbh/swift-coverage-action@v5; kept id: coverage-files + search-paths: .build; removed fail-on-empty-output: true
• Codecov steps: removed verbose: true; kept fail_ci_if_error: false, flags:, token:, files:
• build-macos-platforms: removed the watchOS ENABLE_WATCHOS gate (watchOS now always runs); added a visionOS matrix leg
• No build-only added to standard legs

Config

• .spi.yml normalized (swift_version: 6.1, documentation target Plot)
• .devcontainer/devcontainer.json image → swiftlang/swift:nightly-6.4.x-noble (image line only)

Sundell fork attribution (preserved, not modified)

• Added NOTICE at repo root crediting original work © 2019 John Sundell (MIT) and modifications © 2026 BrightDigit
• Added a fork-notice blockquote near the top of README.md
• Hardened Scripts/header.sh with a guard that skips any file whose first 25 lines contain "Sundell", so the header rewriter can never clobber upstream copyright headers
• Verified: no existing source headers changed — git diff shows zero changes under Sources/, Tests/, and LICENSE is untouched

Agent tooling

• RELEASE_NOTES.md (## Unreleased) summarizing the fork bring-up (from PR Sync subrepo branch brightdigit-com-260406 #1), noting it is a BrightDigit fork of Sundell's Plot
• .claude/agent-notes.md, Memory & Corrections Convention appended to CLAUDE.md, and .claude/skills/

Sundell attribution preservation

The MIT license requires keeping John Sundell's original copyright and permission notices verbatim. This PR preserves every existing source-file header and the LICENSE unchanged, and adds fork attribution (NOTICE + README note) alongside a header.sh guard so future header runs will not rewrite upstream-attributed files.

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9c13297a-3dbc-42d3-b321-5315fa8bdb07

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch brightdigit-com-260406-feedback-fixes

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.28%. Comparing base (c357a8a) to head (a88098c).

Additional details and impacted files

@@                   Coverage Diff                   @@
##           brightdigit-com-260406       #2   +/-   ##
=======================================================
  Coverage                   99.28%   99.28%           
=======================================================
  Files                          70       70           
  Lines                        1398     1398           
=======================================================
  Hits                         1388     1388           
  Misses                         10       10           

Flag	Coverage Δ
macos	99.28% <ø> (ø)
noble	99.28% <ø> (ø)
spm	99.28% <ø> (ø)
swift-6.4	99.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.