Bump golangci-lint to latest and fix issues#4410
Merged
stefanvanburen merged 4 commits intomainfrom Mar 24, 2026
Merged
Conversation
via `make copyfrommakego`. Only a couple of valid lints, and a lot of ignores from `gosec` (unfortunately).
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
stefanvanburen
added a commit
to bufbuild/makego
that referenced
this pull request
Mar 24, 2026
In bufbuild/buf#4383 I failed to notice that protoc was a makego dep; pulling in the latest via `copyfrommakego` in bufbuild/buf#4410 is reverting this change. May as well bump to latest. Ref: https://github.com/protocolbuffers/protobuf/releases
Because of bufbuild/makego#281, we're now dealing with a symlink; update the handling to match. Still not quite right as we're manually updating the PROTOC_VERSION here to match what we already have in this repo, overriding makego's managed version. We should get in bufbuild/makego#295.
Need to compute the include path from the unresolved path before resolving the symlink.
emcfarlane
approved these changes
Mar 24, 2026
Member
Author
|
This needed a few further adjustments because of bufbuild/makego#281. |
Member
Author
|
Going to land this, but we also ought to get in bufbuild/makego#295 shortly since our |
stefanvanburen
added a commit
to bufbuild/makego
that referenced
this pull request
Mar 24, 2026
In bufbuild/buf#4383 I failed to notice that protoc was a makego dep; pulling in the latest via `copyfrommakego` in bufbuild/buf#4410 is reverting this change. May as well bump to latest. Ref: https://github.com/protocolbuffers/protobuf/releases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
via
make copyfrommakego. Only a couple of valid lints, and a lot of ignores fromgosec(unfortunately).