Allow limiting the size of LruBitmapPool/MemoryCache when in background #5546
+122
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This is probably not a good idea. It'll cause a regression in performance for apps that would like to retain cached images in the background. The existing logic already decreases memory usage when the app is backgrounded, just not all the way to empty. That happens in onLowMemory I don't think the atomic boolean here is useful these methods are all executed on the UI thread. |
copybara-service
bot
force-pushed
the
test_774983423
branch
from
f41ca04 to
f7e4de2
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_774983423
branch
2 times, most recently
from
9d7bda3 to
65596f0
Compare
grcruzito924-max
approved these changes
Dec 13, 2025
copybara-service
bot
force-pushed
the
test_774983423
branch
3 times, most recently
from
0cad726 to
0e0a308
Compare
copybara-service
bot
force-pushed
the
test_774983423
branch
from
0e0a308 to
5e0784c
Compare
When an app is moved to background, onTrimMemory() will be called, and LruBitmapPool/MemoryCache will be trimmed. However, the app could keep running and will new bitmaps will be retired to MemoryCache and LruBitmapPool. This change limits the sizes of LruBitmapPool/MemoryCache to zero when the app is in background, and restore the sizes to normal when it's moved out of background. We introduce an experimental API `setMemoryCategoryInBackground(MemoryCategory)` for this purpose, as well as a new `MemoryCategory.ZERO` for no pooling/caching. App can use this API to set the MemoryCategory to limit the pool/cache size when the app is in background. PiperOrigin-RevId: 774983423
copybara-service
bot
force-pushed
the
test_774983423
branch
from
5e0784c to
b6f0c0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow limiting the size of LruBitmapPool/MemoryCache when in background
When an app is moved to background, onTrimMemory() will be called, and LruBitmapPool/MemoryCache will be trimmed. However, the app could keep running and will new bitmaps will be retired to MemoryCache and LruBitmapPool. This change limits the sizes of LruBitmapPool/MemoryCache to zero when the app is in background, and restore the sizes to normal when it's moved out of background.
We introduce an experimental API
setMemoryCategoryInBackground(MemoryCategory)for this purpose, as well as a newMemoryCategory.ZEROfor no pooling/caching. App can use this API to set the MemoryCategory to limit the pool/cache size when the app is in background.