Repository navigation
Add support for custom scrollbars in Grid and MultiGrid - #1532
Closed
fazouane-marouane wants to merge 10 commits into
Closed
fazouane-marouane wants to merge 10 commits into
fazouane-marouane wants to merge 10 commits into
Conversation
Author
|
Closing this as it hasn't been reviewed since its creation (9 months) |
Owner
|
Sorry for the very long delay in getting back to you about this! I've just finished a large update for version 10 of react-virtualized (#1900): the library has been rewritten in TypeScript, every component is now a function component (React 18+ is required), and the source moved from If you're still interested in this change, I'd welcome a new PR with it rebased onto the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi !
The issue of having custom scrollbars with react-virtualized is a pending issue #1275 .
It may be possible to do it today with Lists but it's kind of impossible/hacky to do it for Grid or MultiGrid (by subclassing Grid and using
React.cloneElementfor instance).This PR solves this.
checklist:
npm test) all passyarn run prettier).yarn run typecheck).