feat: add request log #220
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds request logging functionality to the search_objects tool handler, bringing it into parity with the execute_sql and custom tool handlers. The implementation tracks all search operations including their success status, duration, client identifier, and error messages.
Key Changes:
- Added request tracking infrastructure by importing
requestStoreandgetClientIdentifier - Modified error handling to capture error messages before returning error responses
- Implemented request logging in a
finallyblock to ensure all invocations are tracked
| } finally { | ||
| // Track the request | ||
| requestStore.add({ | ||
| id: crypto.randomUUID(), | ||
| timestamp: new Date().toISOString(), | ||
| sourceId: effectiveSourceId, | ||
| toolName: effectiveSourceId === "default" ? "search_objects" : `search_objects_${effectiveSourceId}`, | ||
| sql: `search_objects(object_type=${object_type}, pattern=${pattern}, schema=${schema || "all"}, table=${table || "all"}, detail_level=${detail_level})`, | ||
| durationMs: Date.now() - startTime, | ||
| client: getClientIdentifier(extra), | ||
| success, | ||
| error: errorMessage, | ||
| }); |
There was a problem hiding this comment.
The new request logging functionality lacks test coverage. While the repository has comprehensive test coverage for the search_objects tool (835 lines of tests), there are no tests verifying that requests are correctly logged to the requestStore with the appropriate success/failure status, error messages, duration, client identifier, and other fields. Consider adding tests similar to those in the requests integration tests to verify this new logging behavior.
No description provided.