Skip to content

feat(postgresql): implement automated keyword management and grammar improvements #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
h3n4l merged 6 commits into from
Nov 13, 2025
Merged

feat(postgresql): implement automated keyword management and grammar improvements #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c6b602f
feat(postgresql): implement automated keyword management system
h3n4l Nov 13, 2025
3859fde
refactor(postgresql): remove non-standard builtin_function_name tokens
h3n4l Nov 13, 2025
faaf058
fix(postgresql): add jsontype rule and fix REVERSE keyword
h3n4l Nov 13, 2025
0be2828
chore: update keyword generation timestamp
h3n4l Nov 13, 2025
3a30852
chore: remove one-time cleanup script and update README
h3n4l Nov 13, 2025
557943e
chore: update
h3n4l Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,5 @@ go.work.sum
**/*.class

# No binary files
**/bin/**
**/bin/**
.vscode/
16 changes: 13 additions & 3 deletions postgresql/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,17 @@
all: build test

build:
# Generate keyword definitions from PostgreSQL official source
generate-keywords:
@echo "Generating PostgreSQL keyword definitions from REL_18_STABLE..."
cd keyword-generator && go run main.go
@echo ""

# Build the parser (depends on keyword generation)
build: generate-keywords
Copy link

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Makefile creates a dependency where build always runs generate-keywords first. This means every build will fetch keywords from the PostgreSQL GitHub repository, which could:

  1. Cause build failures if GitHub is unavailable
  2. Slow down builds significantly due to network calls
  3. Make builds non-deterministic if PostgreSQL updates their keywords

Recommendation: Consider removing the dependency and only running generate-keywords explicitly when needed, or check if generated files exist before regenerating them.

Suggested change
build: generate-keywords
build:

Copilot uses AI. Check for mistakes.
@echo "Building PostgreSQL parser..."
antlr -Dlanguage=Go -package postgresql -visitor -o . PostgreSQLLexer.g4 PostgreSQLParser.g4

test:
go test -v -run TestPostgreSQLParser
test:
go test -v -run TestPostgreSQLParser

.PHONY: all build test generate-keywords
Loading