Added node compat example#1223
Merged
vados-cosmonic merged 4 commits intobytecodealliance:mainfrom Feb 25, 2026
Merged
Conversation
Collaborator
vados-cosmonic
left a comment
vados-cosmonic
left a comment
There was a problem hiding this comment.
Thanks for working on this @MendyBerger -- this example is a great start to showing how to do NodeJS compat ahead of a more built-in integration with Jco/other ecosystem projects.
vados-cosmonic
approved these changes
Feb 25, 2026
vados-cosmonic
force-pushed
the
node-example
branch
from
1df6bbe to
c93e2dc
Compare
vados-cosmonic
force-pushed
the
node-example
branch
from
c93e2dc to
db4f2bb
Compare
vados-cosmonic
force-pushed
the
node-example
branch
from
db4f2bb to
328f904
Compare
Collaborator
|
Looks like GHA is having a bad time -- going to go ahead and merge this in since tests work locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also #1206
I'm not sure that this fully resolves the issue, as setting this up took quite a bit of research on how to make unenv work nicely with rollup, and someone with a slightly different build setup would have to figure it out on their own.
Having jco bundle in all this polyfill code with the glue code would make the experience so much better.
Also, turns out unenv has a lot more holes than I originally thought. A significant amount of node apis just trap, and there's no clear documentation on what parts are actually implemented.