Fix merge imports based on semver#2492
Closed
fibonacci1729 wants to merge 1 commit intobytecodealliance:mainfrom
Closed
Fix merge imports based on semver#2492fibonacci1729 wants to merge 1 commit intobytecodealliance:mainfrom
fibonacci1729 wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>
Collaborator
|
Looks reasonable, but CI is unhappy. |
Contributor
Author
|
Closing this to further investigate. #2493 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2451 introduced
topologically_sort_interfacesand correctly calls it at the end ofResolve::merge_packagesafter modifying interface dependencies. However,merge_world_imports_based_on_semverwas not updated with the same fix.merge_world_imports_based_on_semvercallsupdate_interface_dep_of_typeto rewire type aliases from older semver-compatible interfaces to their newer replacements. This changes the dependency edges in the interface graph: an interfaceAthat previously pointed toB_old(positioned beforeAin the arena) may now point toB_new(positioned afterA). This violates the topological ordering invariant thatassert_topologically_sortedchecks.The
mergepath already handled this by callingself.topologically_sort_interfaces(...)after modifying type references, but the semver deduplication path was missed.