Merge wasm_tag type into wasm_functype / clean up C API tag headers#12803
Open
bacek wants to merge 2 commits intobytecodealliance:mainfrom
Open
Merge wasm_tag type into wasm_functype / clean up C API tag headers#12803bacek wants to merge 2 commits intobytecodealliance:mainfrom
bacek wants to merge 2 commits intobytecodealliance:mainfrom
Conversation
Contributor
Author
|
PR in wasm-c-api WebAssembly/wasm-c-api#197 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
- Move tag type info into wasm.h alongside other core types instead of a separate wasmtime/tag.h header - Remove wasmtime/tag.h (contents merged into wasm.h / wasm.hh) - Update extern.hh and tag.hh to reflect new layout - Add tag param accessors in func.rs - Refactor tag.rs to match updated C API surface - Update tag_type.cc tests accordingly Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
@alexcrichton looks like I slightly screwed on upstream PR. Doc build is failing with |
Contributor
Author
Nevermind. Found |
Add Doxygen documentation for the `wasm_tagtype_t` type and its associated functions (`wasm_tagtype_new`, `wasm_tagtype_functype`, vec helpers, and externtype conversion functions). Also document `WASM_EXTERN_TAG` and the `wasm_tagtype_as_externtype*` / `wasm_externtype_as_tagtype*` conversion functions. Fix pre-existing typo: `wasm_name_new_new_uninitialized` -> `wasm_name_new_uninitialized`. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream wasm-c-api was updated to include
Tag. This is migration from wasmtime specific to the upstream.