Enable gc feature by default#12805
Open
tolumide-ng wants to merge 2 commits intobytecodealliance:mainfrom
Open
Enable gc feature by default#12805tolumide-ng wants to merge 2 commits intobytecodealliance:mainfrom
tolumide-ng wants to merge 2 commits intobytecodealliance:mainfrom
Conversation
crates/c-api/Cargo.toml
Outdated
|
|
||
| [features] | ||
| # WASMTIME_FEATURE_LIST | ||
| default = ["gc"] |
Member
There was a problem hiding this comment.
Oh for this the default feature lives here instead which includes gc, so I think it's reasonable to just from [dependencies]
Author
There was a problem hiding this comment.
Thank you for your response @alexcrichton, I am missing part of your suggestion here. Do you mean removing gc as a default feature in' wasmtime/Cargo. toml' and adding #[cfg(feature = "gc")] to the affected parts?
tolumide-ng
force-pushed
the
fix/wasmtime-c-api-gc-update
branch
from
0fb765b to
2569780
Compare
- Remove gc from default on c-api - Adds fallback implementation for when gc is not enabled
tolumide-ng
force-pushed
the
fix/wasmtime-c-api-gc-update
branch
from
2569780 to
ba53a43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
c-apicrate currently enables thegcfeature on itswasmtimedependency, even though it exposes agcfeature to control this behaviour. This prevents downstream users from disablinggc, sinceCargo.tomldoesn't allow overriding it. However, structs likeRootScopeare only available whengcis enabled. Removing it from default features, without other options, would break internal implementations.Changes
gcfeature via the wasmtime-c-api crate by default.gcfeature for thewasmtimedependency inc-api, thus enabling downstream users to specify this behaviour.Closes #12783