Skip to content

Add cargo vet audit for region to 4.0.0 - #14129

Merged
fitzgen merged 1 commit into
bytecodealliance:mainfrom
fitzgen:update_region
Aug 13, 2026
Merged

Add cargo vet audit for region to 4.0.0#14129
fitzgen merged 1 commit into
bytecodealliance:mainfrom
fitzgen:update_region

Conversation

@fitzgen

@fitzgen fitzgen commented Aug 12, 2026

Copy link
Copy Markdown
Member

#14119 but with an audit

@fitzgen
fitzgen requested review from a team as code owners August 12, 2026 19:17
@fitzgen
fitzgen requested review from alexcrichton and removed request for a team August 12, 2026 19:17
@fitzgen fitzgen mentioned this pull request Aug 12, 2026
@alexcrichton
alexcrichton enabled auto-merge August 12, 2026 19:19
@alexcrichton
alexcrichton added this pull request to the merge queue Aug 12, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 12, 2026
@alexcrichton

Copy link
Copy Markdown
Member

We've been having a lot of spurious failures lately, but that one I think is legitimate:

     Running unittests src\lib.rs (target\debug\deps\cranelift_jit-be19be230b13c5cb.exe)

running 3 tests
test memory::arena::tests::test_is_send ... ok
test memory::arena::tests::over_capacity ... FAILED
test memory::arena::tests::alignment_ok ... FAILED

failures:

---- memory::arena::tests::over_capacity stdout ----

thread 'memory::arena::tests::over_capacity' (7000) panicked at cranelift\jit\src\memory\arena.rs:44:18:
unable to change memory protection for jit memory segment: SystemCall(487)

---- memory::arena::tests::alignment_ok stdout ----

thread 'memory::arena::tests::alignment_ok' (2564) panicked at cranelift\jit\src\memory\arena.rs:44:18:
unable to change memory protection for jit memory segment: SystemCall(487)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    memory::arena::tests::alignment_ok
    memory::arena::tests::over_capacity

test result: FAILED. 1 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

@alexcrichton

Copy link
Copy Markdown
Member

Also, for reasons like this, I'd recommend pushing vets to contributors' PRs since @fitzgen you're semi-on-the-hook for resolving this now

@alexcrichton

Copy link
Copy Markdown
Member

(cc @bjorn3 as well since you're likely interested in the failure)

@github-actions github-actions Bot added the cranelift Issues related to the Cranelift code generator label Aug 12, 2026
@fitzgen fitzgen changed the title Update region to 4.0.0 Add cargo vet audit for region to 4.0.0 Aug 13, 2026
@fitzgen
fitzgen enabled auto-merge August 13, 2026 17:05
@fitzgen

fitzgen commented Aug 13, 2026

Copy link
Copy Markdown
Member Author

Dropped the actual region dependency update from this PR, leaving just the audit.

@bjorn3 feel free to rebase your dependency update on top of this and make a new PR when you've figured out the issues that CI surfaced, which won't need a cargo vet audit anymore after this lands

@fitzgen
fitzgen added this pull request to the merge queue Aug 13, 2026
Merged via the queue into bytecodealliance:main with commit eba60a7 Aug 13, 2026
53 checks passed
@fitzgen
fitzgen deleted the update_region branch August 13, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cranelift Issues related to the Cranelift code generator

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants