Repository navigation
feat(touchable-ripple)!: state-layer opacity via ripple alpha (#4972) - #5177
Open
Priyanshu0007 wants to merge 2 commits into
Open
Priyanshu0007 wants to merge 2 commits into
Priyanshu0007 wants to merge 2 commits into
Conversation
Collaborator
|
We'd like this PR to carry the
|
This was referenced Nov 6, 2026
…ack#4972) BREAKING CHANGE: Removes theme.colors.stateLayerPressed. - Remove stateLayerPressed color token from theme and color definitions. - Default TouchableRipple ripple color to theme.colors.onSurface. - Automatically apply Material 3 pressed state layer opacity (0.10) via android_ripple.alpha on Android, color.alpha() on Web, and underlay opacity on iOS. - Preserve explicit underlayColor on iOS without forcing underlay opacity. - Pass container's stateLayer (on-color) to TouchableRipple in FAB Shell and FAB Menu items, and update morphing trigger variant when expanded. - Update 6.x migration documentation and test snapshots.
- Fallback to Palette.neutral10/90 when rippleColor or onSurface is a PlatformColor on Android - Prevent invariant error in useAndroidRippleForView when using dynamic themes - Add tests covering PlatformColor ripple fallback
Priyanshu0007
force-pushed
the
feat/remove-state-layer-pressed
branch
from
November 6, 2026 18:46
2b1a538 to
502cb52
Compare
Author
|
Hi @Doberjohn, i have made changes requested by you. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #4972. Removes
stateLayerPressedfor Paper 6.0 in favor of runtime ripple alpha calculation inTouchableRipple.Thanks to @adrcotfas for the initial implementation and draft in #4997.
Merge Order Note
On Android,
TouchableRipplenow applies0.10alpha directly. In #5097,Buttonstill bakes0.10alpha into its ripple color. Whichever PR lands second must updateButtonto pass its fully opaque label color to avoid multiplying opacity down to ~1%.Test Evidence
android_ripple.mp4
ios_ripple.mp4
web_ripple.mp4