Improve gyp-to-cmake to handle "cflags" #99

Activity

1. kraenhansen

   added

   enhancementNew feature or requestNew feature or request

   gyp-to-cmake

   good first issueGood for newcomersGood for newcomers

   on May 21, 2025
2. huytdps13400 commented on Aug 23, 2026

   

   huytdps13400

   on Aug 23, 2026

   Contributor

   More actions

   /claim

   I’ve reproduced the gap with a two-stage TDD fixture:

   1. parser validation now has red coverage for accepting cflags: string[] and rejecting malformed values;
   2. transformer coverage is red because neither a normal nor namespaced target emits target_compile_options.

   I’ll keep this scoped to issue #99: map target-level GYP cflags to private CMake compile options, preserve command expansion and space escaping, and leave cflags_cc, ldflags, variables, conditions, and target defaults for their separate issues.
3. huytdps13400 commented on Aug 23, 2026

   

   huytdps13400

   on Aug 23, 2026

   Contributor

   More actions

   Implemented in #454.

   Target-level GYP cflags are now validated as string arrays and emitted as private CMake target_compile_options, including command expansion, escaped spaces, and namespaced target handling.

   Verification on Node 24.16.0 / pnpm 10.33.0: focused 38/38, root matrix 115/115, build, lint, Prettier, depcheck, and diff checks all pass.