Add transformation of "defines" to gyp-to-cmake#97
Conversation
|
matthargett
left a comment
matthargett
left a comment
There was a problem hiding this comment.
Some immediate comments to validate against Windows. With Windows CI now set up, you should be able to run the tests there and have a feedback loop to make sure all the platforms are making decent progress in lock-step :)
|
|
||
| function escapePath(source: string) { | ||
| function escapeSpaces(source: string) { | ||
| return source.replace(/ /g, "\\ "); |
There was a problem hiding this comment.
Windows needs quotes around paths with spaces
| targets: [ | ||
| { | ||
| target_name: "foo", | ||
| sources: ["<!echo bar baz"], |
There was a problem hiding this comment.
unclear that this will work on Windows, at least without quotes. we probably want to specify PowerShell explicitly on that platform, and code to that.
3 participants
This fixes #96 by adding transformation of "defines".
Merging this PR will:
binding.gypfile.gyp-to-cmake#9)