fix: replace deprecated 409 CONFLICT error code (#165) - #166
Merged
caubut-charter merged 1 commit intoJul 24, 2026
Merged
caubut-charter merged 1 commit into
caubut-charter merged 1 commit into
Conversation
Commonalities deprecated the 409 CONFLICT error code (PR #569); HTTP status 409 is retained. Replace NAM's explicit CONFLICT references with the applicable non-deprecated 409 codes: - createTrustDomain, createTrustDomainDevice, createRebootRequest -> ALREADY_EXISTS - updateRebootRequest -> INCOMPATIBLE_STATE Updates the API definitions, the createTrustDomain feature test, and the two Trust Domain user stories, and applies the README wording fix from the camaraproject#164 review.
clundie-CL
requested review from
benhepworth,
caubut-charter and
mayur007
as code owners
July 24, 2026 12:11
clundie-CL
added a commit
that referenced
this pull request
Jul 24, 2026
8 tasks
clundie-CL
added a commit
that referenced
this pull request
Jul 24, 2026
* Update README Release Information for r3.1 * Add CHANGELOG draft for r3.1 * Revise CHANGELOG for network-access APIs Updated the changelog for the network-access-devices and network-access-domains APIs, detailing breaking changes, additions, modifications, and the new input-validation response. * docs: add 409-code alignment (#166) to r3.1 CHANGELOG; trim unchanged ICM dependency * docs: restructure 409 change per RM review (Breaking/Added/Removed); note deviceStatus; extend README scope --------- Co-authored-by: camara-release-automation[bot] <261643975+camara-release-automation[bot]@users.noreply.github.com> Co-authored-by: Cody Lundie <c.lundie@cablelabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Resolves the Commonalities non-conformance raised in #165 (release-review of #164). Commonalities
deprecated the
409 CONFLICTerror code (PR #569, from r4.1 / 0.7.0, still deprecated at r4.3 /0.8.0). HTTP status 409 is retained — only the body
code: CONFLICTis deprecated — so NAM'sexplicit
CONFLICTreferences are replaced with the applicable non-deprecated 409 codes:createTrustDomain(duplicate name)ALREADY_EXISTScreateTrustDomainDevice(duplicate registration)ALREADY_EXISTScreateRebootRequest(duplicate pending reboot)ALREADY_EXISTSupdateRebootRequest(state conflict)INCOMPATIBLE_STATEChanges:
network-access-devices.yaml) and added aone-line note to each 409-returning create/update operation naming the specific code.
network-access-domains-createTrustDomain.featurenow asserts$.code == "ALREADY_EXISTS".specific code (
409 Conflict (ALREADY_EXISTS)/(INCOMPATIBLE_STATE)).The shared
code/common/CAMARA_common.yamlGeneric409is unchanged — it is the canonical r4.3artifact (it retains
CONFLICTas a deprecated example, matching upstream).Which issue(s) this PR fixes:
Fixes #165
Does this PR introduce a breaking change?
Special notes for reviewers:
warnings;
redocly lintvalid on both specs; no NAM-authoredCONFLICTremains(
grepconfirms only the canonical deprecated example inCAMARA_common.yaml).x-camara-commonalitiesis intentionally not touched here —/create-snapshotstamps the pinnedrelease semver at snapshot time (the discarded r3.1 snapshot already showed
0.8.0).being tracked separately as per-finding issues.
Changelog input
Additional documentation
This section can be blank.