Add validation for --benchmark-samples to prevent crash with zero value #3056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## devel #3056 +/- ##
==========================================
- Coverage 91.03% 91.03% -0.00%
==========================================
Files 202 202
Lines 8727 8736 +9
==========================================
+ Hits 7944 7952 +8
- Misses 783 784 +1 🚀 New features to boost your workflow:
|
Author
|
also added test for "could not parse ... as benchmark samples" return |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds validation for
--benchmark-samples=0to prevent a crash,adds an automated self-test, and updates approval baselines.
PR is based on the request #3041
Fixes #3040