Preserve dict LIFO order in Box.popitem

AUTHORS.rst

@@ -37,6 +37,7 @@ Code contributions:
 - Jesper Schlegel (jesperschlegel)
 - J vanBemmel (jbemmel)
 - m-janicki
+- machines-6657 (machines-6657)
 
 
 Suggestions and bug reporting:

CHANGES.rst

@@ -1,6 +1,11 @@
 Changelog
 =========
 
+Unreleased
+----------
+
+* Fix `Box.popitem()` to remove the most recently inserted item, matching `dict.popitem()`.
+
 Version 7.4.1
 -------------
 

box/box.py

@@ -782,7 +782,7 @@ def popitem(self):
         if self._box_config["frozen_box"]:
             raise BoxError("Box is frozen")
         try:
-            key = next(self.__iter__())
+            key = next(self.__reversed__())
         except StopIteration:
             raise BoxKeyError("Empty box") from None
         return key, self.pop(key)

test/test_box.py

@@ -882,7 +882,8 @@ def test_pop(self):
         assert bx.pop("c", True) is not True
 
     def test_pop_items(self):
-        bx = Box(a=4)
+        bx = Box(a=4, b=5)
+        assert bx.popitem() == ("b", 5)
         assert bx.popitem() == ("a", 4)
         with pytest.raises(BoxKeyError):
             assert bx.popitem()